[Cogl] [PATCH v3] Adds initial GLES2 integration support
Robert Bragg
robert at sixbynine.org
Thu May 17 06:07:39 PDT 2012
Ok, I think we've got there in the end.
Sorry that some of the updates were a bit sloppy; I've fixed the silly
thinkos you pointed out, and I've pushed the patch set to master.
kind regards,
- Robert
On Wed, May 16, 2012 at 4:11 PM, Neil Roberts <neil at linux.intel.com> wrote:
> Looks good, thanks. I still have some really minor changes to suggest
> though -
>
> • I couldn't get it to build to build without including cogl-queue.h
> from cogl-gles2-context-private.h. Not sure why, but this was building
> for WebOS so maybe other builds end up including it via something
> else?
>
> • The wrapper for glCopyTexSubImage2D actually calls glCopyTexImage2D
>
> • A _COGL_RETURN_IF_FAIL assertion wasn't updated to use the inline
> GQueue so it wouldn't compile.
>
> Here's the changes in patch form to squash in if you want.
>
> Otherwise looks good to me.
>
> Reviewed-by: Neil Roberts <neil at linux.intel.com>
>
> Regards,
> - Neil
>
More information about the Cogl
mailing list