[Cogl] [PATCH 2/2] error: Don't allocate a new CoglError when propagating

[Neil Roberts]

Robert Bragg wrote:

> I think the reason I originally did it the other way was because
> this api used to be called _cogl_propogate_gerror() and was intended
> to propogate an error e.g. from gdk-pixbuf. Although it's unlikely
> someone would build cogl with --without-glib and still use
> gdk-pixbuf but in that case we shouldn't just be stealing the
> message and GError pointers.

Ok, yeah, that makes sense. However, I don't think it would work as it
stands anyway because the existing code tries to free the GError using
cogl_error_free. That would end up using the internal copy of the
slice allocator which would probably not work.

Maybe we should just make the configure script disable disallow using
--enable-gdk-pixbuf with --disable-glib because it's quite a weird
thing to do anyway. I'm posting a couple of patches to make that work.

- Neil