[Cogl] [PATCH] texture: expose mipmap level in set region apis

Neil Roberts neil at linux.intel.com
Tue Nov 27 08:58:02 PST 2012


I wrote:

>> Isn't that loop equivalent to this?
>>
>> current_width = MAX (1, current_width >> level);
>> /* etc */

Having complained about your loop, I just noticed I wrote the same
loop for the cogl_offscreen_new_to_texture_full function:

http://git.gnome.org/browse/cogl/tree/cogl/cogl-framebuffer.c?id=5fb4a6178#n593

If you can be bothered it might be worth making this use your function
instead.

Regards,
- Neil
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



More information about the Cogl mailing list