[Cogl] [PATCH] framebuffer: Annotate the output parameter of get_viewport4fv()

Robert Bragg robert at sixbynine.org
Mon Oct 1 05:56:40 PDT 2012


This looks good to land to me:

Reviewed-by: Robert Bragg <robert at linux.intel.com>

thanks,
- Robert

On Mon, Oct 1, 2012 at 1:26 AM, Damien Lespiau <damien.lespiau at gmail.com> wrote:
> From: Damien Lespiau <damien.lespiau at intel.com>
>
> Annotate that the float* is an out parameter that points to a caller
> allocated array of 4 floats.
> ---
>  cogl/cogl-framebuffer.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/cogl/cogl-framebuffer.h b/cogl/cogl-framebuffer.h
> index 62a02ca..c1295b8 100644
> --- a/cogl/cogl-framebuffer.h
> +++ b/cogl/cogl-framebuffer.h
> @@ -231,7 +231,8 @@ cogl_framebuffer_get_viewport_height (CoglFramebuffer *framebuffer);
>  /**
>   * cogl_framebuffer_get_viewport4fv:
>   * @framebuffer: A #CoglFramebuffer
> - * @viewport: A pointer to an array of 4 floats to receive the (x, y, width, height)
> + * @viewport: (out caller-allocates) (array fixed-size=4): A pointer to an
> + *            array of 4 floats to receive the (x, y, width, height)
>   *            components of the current viewport.
>   *
>   * Queries the x, y, width and height components of the current viewport as set
> --
> 1.7.7.5
>
> _______________________________________________
> Cogl mailing list
> Cogl at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/cogl


More information about the Cogl mailing list