[Cogl] [PATCH 2/3] Remove an out of date comment in the GLES2 context code

Robert Bragg robert at sixbynine.org
Mon Oct 1 05:57:12 PDT 2012


This looks good to land to me:

Reviewed-by: Robert Bragg <robert at linux.intel.com>

thanks,
- Robert

On Mon, Oct 1, 2012 at 12:06 PM, Neil Roberts <neil at linux.intel.com> wrote:
> There was a FIXME comment about making glCopyTex{Sub,}Image2D work
> with CoglOffscreen buffers. This has already been fixed so we should
> remove the comment.
> ---
>  cogl/cogl-gles2-context.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/cogl/cogl-gles2-context.c b/cogl/cogl-gles2-context.c
> index 65e7598..fa580dd 100644
> --- a/cogl/cogl-gles2-context.c
> +++ b/cogl/cogl-gles2-context.c
> @@ -1642,10 +1642,6 @@ cogl_gles2_context_new (CoglContext *ctx, CoglError **error)
>    gles2_ctx->vtable->glBindTexture = gl_bind_texture_wrapper;
>    gles2_ctx->vtable->glTexImage2D = gl_tex_image_2d_wrapper;
>
> -  /* FIXME: we need to do something with glCopyTexImage2D and
> -   * glCopySubTexImage2D so that it will flip the data if it is read
> -   * from a CoglOffscreen */
> -
>    gles2_ctx->shader_map =
>      g_hash_table_new_full (g_direct_hash,
>                             g_direct_equal,
> --
> 1.7.11.3.g3c3efa5
>
> _______________________________________________
> Cogl mailing list
> Cogl at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/cogl


More information about the Cogl mailing list