[Cogl] [PATCH] tweak: Support retrieving depth textures from framebuffers

Neil Roberts neil at linux.intel.com
Fri Sep 7 03:23:12 PDT 2012


Thanks. This looks good to land to me.

Reviewed-by: Neil Roberts <neil at linux.intel.com>

Regards,
- Neil

Robert Bragg <robert at sixbynine.org> writes:

> From: Robert Bragg <robert at linux.intel.com>
>
> Ok I went with renaming the enable_ function to
> set_depth_texture_enabled. Although I'm quite tempted by the idea of
> using other verbs than 'set' and 'get' for some reason I was feeling
> conservative since we have no precedent for that in Cogl currently.
>
> That said it really is quite verbose now so maybe it would be worth
> introducing _enable and _disable verbs.
>
> This patch should hopefully address the points you raised, and
> should be folded back into Damien's original patch.
>
> kind regards,
> - Robert


More information about the Cogl mailing list