[Cogl] [PATCH 5/8] build: Move the compiler checks and libtool initialization up

Robert Bragg robert at sixbynine.org
Wed Sep 19 08:11:05 PDT 2012


Okey, that look good to me so I'd say this is good to land:

Reviewed-by: Robert Bragg <robert at linux.intel.com>

thanks,
- Robert

On Wed, Sep 19, 2012 at 2:04 PM, Lespiau, Damien
<damien.lespiau at intel.com> wrote:
> On Tue, Sep 18, 2012 at 3:34 PM, Robert Bragg <robert at sixbynine.org> wrote:
>> I haven't looked into this in detail but I was having some libtool
>> problems trying to build the wip/standalone branch in a clean build
>> directory because it wasn't creating a ./libtool script.
>
> Yes, I stumbled on this as well today and fixed it in a patch that can
> be folded into the big one (this is what glib's configure.ac does):
>
> From 1ee4067a5bab83e23e185d2be10b457c5c74f9cb Mon Sep 17 00:00:00 2001
> From: Damien Lespiau <damien.lespiau at intel.com>
> Date: Wed, 19 Sep 2012 12:50:04 +0000
> Subject: build: Create the libtool file early as it's used by AS_GLIBCONFIG
>
> glib's configure.ac uses libtool to determine the extension of shared
> libraries. So let's generate the libtool file early in configure.
> ---
> diff --git a/configure.ac b/configure.ac
> index 39d7694..ff99252 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -160,6 +160,9 @@ dnl AC_PROG_LIBTOOL
>  dnl LIBTOOL="$LIBTOOL --preserve-dup-deps"
>  LT_PREREQ([2.2.6])
>  LT_INIT([disable-static])
> +dnl when using libtool 2.x create libtool early, because it's used in the
> +dnl internal glib configure (as-glibconfig.m4)
> +m4_ifdef([LT_OUTPUT], [LT_OUTPUT])
>
>  dnl ================================================================
>  dnl See what platform we are building for
> --
> cgit v0.9.0.2


More information about the Cogl mailing list