[Cogl] [PATCH 03/13] cogl-gst: video-sink: fix ayuv pipeline setup

Robert Bragg robert at sixbynine.org
Tue Dec 10 09:18:23 PST 2013


Looking at this it seems we should also change the definition of
ayuv_glsl_renderer too which currently looks like this:

static CoglGstRenderer ayuv_glsl_renderer =
{
  "AYUV glsl",
  COGL_GST_AYUV,
  COGL_GST_RENDERER_NEEDS_GLSL,
  GST_STATIC_CAPS (GST_VIDEO_CAPS_MAKE ("AYUV")),
  3, /* n_layers */
  cogl_gst_ayuv_glsl_setup_pipeline,
  cogl_gst_ayuv_upload,
};

I guess we should set n_layers to 1 here too?

If you agree, then maybe we should fold that fix into this patch too?

Regards,
Robert


On Mon, Dec 9, 2013 at 11:17 AM, Lionel Landwerlin
<llandwerlin at gmail.com> wrote:
> ---
>  cogl-gst/cogl-gst-video-sink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cogl-gst/cogl-gst-video-sink.c b/cogl-gst/cogl-gst-video-sink.c
> index a42841a..273c9eb 100644
> --- a/cogl-gst/cogl-gst-video-sink.c
> +++ b/cogl-gst/cogl-gst-video-sink.c
> @@ -797,7 +797,7 @@ cogl_gst_ayuv_glsl_setup_pipeline (CoglGstVideoSink *sink,
>        g_free (source);
>      }
>
> -  setup_pipeline_from_cache_entry (sink, pipeline, entry, 3);
> +  setup_pipeline_from_cache_entry (sink, pipeline, entry, 1);
>  }
>
>  static CoglBool
> --
> 1.8.5
>
> _______________________________________________
> Cogl mailing list
> Cogl at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/cogl


More information about the Cogl mailing list