[Cogl] [PATCH 00/13] Allocate textures lazily

[Neil Roberts]

Hi,

This patch series looks great as it would be really nice to fix the
internal format mess. I just have one comment about the set_components
and set_premultiplied functions. It doesn't seem like a good idea to
override the premultiplied value whenever you set the number of
components because then if you want non-premultiplied RGBA you have to
remember to call set_premultiplied after set_components. I think that
would be kind of difficult to explain in the documentation (if there was
any…). I think it would be better to not have any magic in either of the
functions and just make it so you get what you ask for.

Cogl-GST doesn't compile anymore because Lionel's changes for the yv12
stuff needs some changes to work the these patches.

Apart from that it all looks good to land to me.

Reviewed-by: Neil Roberts <neil at linux.intel.com>

Regards,
- Neil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/cogl/attachments/20131218/e3c58b6a/attachment.pgp>