[Cogl] [PATCH] Reorder some struct members to avoid padding due to alignment

Neil Roberts neil at linux.intel.com
Wed Jan 16 08:48:42 PST 2013


Robert Bragg <robert at sixbynine.org> writes:

> One initial concern I had was that the differences members for
> CoglPipeline and CoglPipelineLayer might be used with the COGL_FLAGS_
> macros somewhere and those expect to deal with longs. A quick grep
> makes me think that actually we don't, although I was a bit surprised
> by that so maybe it's also worth double checking that's the case.

Yeah, I didn't think of that, but as you say it doesn't look like
anything is using those flags with the COGL_FLAGS_ macros.

If COGL_FLAGS_FOREACH_* is used with an integer array it will actually
give a warning so presumably it would have caught that with this patch.

I think the other COGL_FLAGS_* macros would actually just work with an
int as long as there is only one entry in the array, which is true in
this case.

I have pushed this patch and also all of the other ones that were
recently reviewed.

Thanks.

Regards,
- Neil
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



More information about the Cogl mailing list