[Cogl] [PATCH 1/4] Allow cogl_wayland_onscreen_get_surface to be used non-foreignly

Robert Bragg robert at sixbynine.org
Tue Jul 9 05:17:05 PDT 2013


This looks good to land to me:

Reviewed-by: Robert Bragg <robert at linux.intel.com>

thanks,
- Robert


On Thu, Jul 4, 2013 at 1:45 PM, Neil Roberts <neil at linux.intel.com> wrote:
> cogl_wayland_onscreen_get_surface previously only worked if the
> onscreen had a foreign surface on it. However there is no reason why
> this shouldn't also work fine for manipulating the surface that Cogl
> created as well. We may want to consider adding a separate getter for
> the foreign surface that can be used before the framebuffer is
> allocated.
> ---
>  cogl/winsys/cogl-winsys-egl-wayland.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cogl/winsys/cogl-winsys-egl-wayland.c b/cogl/winsys/cogl-winsys-egl-wayland.c
> index 461ed18..0727bbc 100644
> --- a/cogl/winsys/cogl-winsys-egl-wayland.c
> +++ b/cogl/winsys/cogl-winsys-egl-wayland.c
> @@ -636,7 +636,7 @@ cogl_wayland_onscreen_get_surface (CoglOnscreen *onscreen)
>    CoglFramebuffer *fb;
>
>    fb = COGL_FRAMEBUFFER (onscreen);
> -  if (fb->allocated && !onscreen->foreign_surface)
> +  if (fb->allocated)
>      {
>        CoglOnscreenEGL *egl_onscreen = onscreen->winsys;
>        CoglOnscreenWayland *wayland_onscreen = egl_onscreen->platform;
> --
> 1.7.11.3.g3c3efa5
>
> _______________________________________________
> Cogl mailing list
> Cogl at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/cogl


More information about the Cogl mailing list