[Cogl] [PATCH 00/11] Remove automagic texture apis

Neil Roberts neil at linux.intel.com
Thu Jul 11 10:35:11 PDT 2013


This series looks great and is fine to land by me.

It doesn't quite build anymore because test-utils.h no longer includes
cogl.h to avoid the circular dependency. I think it just needs the
following headers to be added:

#include <cogl/cogl-primitive-texture.h>
#include <cogl/cogl-texture-2d-sliced.h>
#include <cogl/cogl-meta-texture.h>
#include <cogl/cogl-atlas-texture.h>

I think we should probably remove the texture migration support from
atlas textures because that also seems a bit too magic. It should only
migrate textures when automatic mipmapping is triggered or if you render
with the primitive API. We could instead just document the restrictions
for atlas textures and consider it an error if they are ignored. We can
leave that for a separate patch though.

Sorry for the delay in reviewing.

Regards,
- Neil
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



More information about the Cogl mailing list