[Cogl] [PATCH 3/3] tests: Adds our first white-box unit test

Neil Roberts neil at linux.intel.com
Tue Jun 4 09:38:51 PDT 2013


This looks good except that I think it is missing
test-fixtures/Makefile.am and test-fixtures/test-unit.h so it won't
compile.

Instead of calling ‘nm’ directly in the Makefile and assuming the
library ends in .so, it might be nicer to use the $(NM) variable and get
the filename from libtool so that it has a better chance of working in
cross-compiled environments and on OS X where the libs aren't called
.so. Maybe something like this?

source $(top_builddir)/cogl/libcogl2.la ; \
$(NM) $(top_builddir)/cogl/.libs/"$$dlname" \
 |grep 'D unit_test_'|sed 's/.\+ D //' > unit-tests

Regards,
- Neil
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


More information about the Cogl mailing list