[Cogl] [PATCH] cogl-path: Fix the uninitialised path->fill_primitive

Robert Bragg robert at sixbynine.org
Wed Jun 12 06:47:57 PDT 2013


This looks good to land to me:

Reviewed-by: Robert Bragg <robert at linux.intel.com>

thanks,
- Robert


On Wed, Jun 12, 2013 at 2:46 PM, Neil Roberts <neil at linux.intel.com> wrote:
> This was not being uninitialised so it was sometimes causing a crash
> when it tried to unref an invalid pointer. This was causing test-path
> to fail for me.
> ---
>  cogl-path/cogl-path.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/cogl-path/cogl-path.c b/cogl-path/cogl-path.c
> index 9a1d1df..be8bb04 100644
> --- a/cogl-path/cogl-path.c
> +++ b/cogl-path/cogl-path.c
> @@ -890,6 +890,7 @@ cogl_path_new (CoglContext *context)
>    data->last_path = 0;
>    data->fill_attribute_buffer = NULL;
>    data->stroke_attribute_buffer = NULL;
> +  data->fill_primitive = NULL;
>    data->is_rectangle = FALSE;
>
>    return _cogl_path_object_new (path);
> --
> 1.7.11.3.g3c3efa5
>
> _______________________________________________
> Cogl mailing list
> Cogl at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/cogl


More information about the Cogl mailing list