[Cogl] [PATCH 13/15] cogl-gst: Move the PARAM macros into the C file

Lionel Landwerlin llandwerlin at gmail.com
Sat Jun 22 01:58:57 PDT 2013


From: Neil Roberts <neil at linux.intel.com>

These are just internal convenience macros to define the GObject
properties so they shouldn't be in the public headers.

Reviewed-by: Robert Bragg <robert at linux.intel.com>

(cherry picked from commit b7b861aa87ad05a2c253afdd87323acd82fd988f)
---
 cogl-gst/cogl-gst-video-sink.c | 12 ++++++++++++
 cogl-gst/cogl-gst-video-sink.h | 12 ------------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/cogl-gst/cogl-gst-video-sink.c b/cogl-gst/cogl-gst-video-sink.c
index 62981d8..6e65402 100644
--- a/cogl-gst/cogl-gst-video-sink.c
+++ b/cogl-gst/cogl-gst-video-sink.c
@@ -58,6 +58,18 @@
 
 #define SINK_CAPS GST_VIDEO_CAPS_MAKE (BASE_SINK_CAPS)
 
+#define COGL_GST_PARAM_STATIC        \
+  (G_PARAM_STATIC_NAME | G_PARAM_STATIC_NICK | G_PARAM_STATIC_BLURB)
+
+#define COGL_GST_PARAM_READABLE      \
+  (G_PARAM_READABLE | COGL_GST_PARAM_STATIC)
+
+#define COGL_GST_PARAM_WRITABLE      \
+  (G_PARAM_WRITABLE | COGL_GST_PARAM_STATIC)
+
+#define COGL_GST_PARAM_READWRITE     \
+  (G_PARAM_READABLE | G_PARAM_WRITABLE | COGL_GST_PARAM_STATIC)
+
 static GstStaticPadTemplate sinktemplate_all =
   GST_STATIC_PAD_TEMPLATE ("sink",
                            GST_PAD_SINK,
diff --git a/cogl-gst/cogl-gst-video-sink.h b/cogl-gst/cogl-gst-video-sink.h
index cabc502..e76e742 100644
--- a/cogl-gst/cogl-gst-video-sink.h
+++ b/cogl-gst/cogl-gst-video-sink.h
@@ -101,18 +101,6 @@ G_BEGIN_DECLS
   (G_TYPE_INSTANCE_GET_CLASS ((obj), \
   COGL_GST_TYPE_VIDEO_SINK, CoglGstVideoSinkClass))
 
-#define COGL_GST_PARAM_STATIC        \
-  (G_PARAM_STATIC_NAME | G_PARAM_STATIC_NICK | G_PARAM_STATIC_BLURB)
-
-#define COGL_GST_PARAM_READABLE      \
-  (G_PARAM_READABLE | COGL_GST_PARAM_STATIC)
-
-#define COGL_GST_PARAM_WRITABLE      \
-  (G_PARAM_WRITABLE | COGL_GST_PARAM_STATIC)
-
-#define COGL_GST_PARAM_READWRITE     \
-  (G_PARAM_READABLE | G_PARAM_WRITABLE | COGL_GST_PARAM_STATIC)
-
 typedef struct _CoglGstVideoSink CoglGstVideoSink;
 typedef struct _CoglGstVideoSinkClass CoglGstVideoSinkClass;
 typedef struct _CoglGstVideoSinkPrivate CoglGstVideoSinkPrivate;
-- 
1.8.3.1



More information about the Cogl mailing list