[Cogl] [PATCH] gst: Comb out bugs from hardware acceleration code

[Neil Roberts]

Thanks again Plamena! I just have a couple of comments:

>    COGL_GST_PKG_REQUIRES="$COGL_GST_PKG_REQUIRES gstreamer-1.0  gstreamer-fft-1.0 \
>                           gstreamer-audio-1.0 gstreamer-base-1.0 \
>                           gstreamer-video-1.0 gstreamer-plugins-base-1.0 \
> -                         gstreamer-tag-1.0 gstreamer-controller-1.0"
> -                         
> +                         gstreamer-tag-1.0 gstreamer-controller-1.0 \
> +                         gstreamer-basevideo-1.0"

It doesn't seem like a good idea to depend on gstreamer-basevideo if it
is only used for the hardware decoding. It is the only thing provided by
gstreamer-plugins-bad so it is one less package to build if we don't
include it.

> +echo "        Has HW suppport ${have_hw_decoder_support}"

We should probably change this to say "CoglGST has HW support", because
otherwise it's not immediately obvious what it is talking about.
Alternatively we could just remove it because it's not possible to
enable the hardware support without hacking the configure script anyway.

Other than that the CoglGST patches look good to land to me if we squash
them all into one.

Regards,
- Neil
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.