[Cogl] [PATCH 1/2] wayland: Don't set the surface to toplevel until it is shown

[Robert Bragg]

ok cool, that sounds good, thanks.

- Robert

On Tue, May 28, 2013 at 2:37 PM, Neil Roberts <neil at linux.intel.com> wrote:
> Thanks for the review.
>
> Robert Bragg <robert at sixbynine.org> writes:
>
>> It seems like we should be adding some documentation to explain this
>> behaviour somewhere, though I'm not exactly sure where. Maybe we could
>> even add a wayland specific note to cogl_onscreen_show()?
>
> Yeah, documenting it will be good. I will add this to
> cogl_onscreen_show() if that's ok:
>
>  * When using the Wayland winsys calling this will set the surface to
>  * a toplevel type which will make it appear. If the application wants
>  * to set a different type for the surface, it can avoid calling
>  * cogl_onscreen_show() and set its own type directly with the Wayland
>  * client API via cogl_wayland_onscreen_get_surface().
>
> cogl_onscreen_show already has a note saying that it's ok to avoid
> calling show and use to the native APIs so I think that should fit in
> ok.
>
> Regards,
> - Neil
> ---------------------------------------------------------------------
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ
> VAT No: 860 2173 47
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
> _______________________________________________
> Cogl mailing list
> Cogl at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/cogl