[Cogl] [PATCH] CoglTexturePixmapX11: add support for stereo content

[Robert Bragg]

Hi Owen,

Thanks for the updated patch without the new texture object.

With regards to keeping the separate struct in the glx code, I don't
really have a strong opinion on that, so this way is ok by me.

> +typedef struct _CoglPixmapTextureInfoGLX
> +{
> +  CoglTexture *glx_tex;
> +  CoglBool bind_tex_image_queued;
> +  CoglBool pixmap_bound;
> +} CoglPixmapTextureInfoGLX;

The only thing I would quite like to tweak if possible, is to try and
find a more distinct, descriptive name for this - it's not really
great having this right next to CoglTexturePixmapInfoGLX.

CoglTexturePixmapEyeGLX perhaps? At a glance that might make it a bit
more obvious why the state is split up.

Can you maybe confirm that you have tested this, beyond the
cogl-x11-tfp test in GnomeShell?

It's not ideal that this extension in likely to remain specific to the
Nvidia proprietary driver for the foreseeable future which pretty much
means I can't test it. That would still basically be true if it were
specific to the open source Nvidia driver, but this seems like a
feature that's not really hardware specific.

Assuming you can find a better name for the struct, and are confident
that you have tested it then I'm happy for this to land:

Reviewed-by: Robert Bragg <robert at sixbynine.org>

--
Thanks,
Robert