[colord] libcolord makes broken profiles?
Richard Hughes
hughsient at gmail.com
Thu Nov 28 07:00:56 PST 2013
On 28 November 2013 13:40, Alexey Galakhov <agalakhov at gmail.com> wrote:
>> Are you using CdIcc to create that file?
> Yes.
Okay, I see the problem, well, two problems -- the first is kinda
subtle, it's a two line fix but a large testcase:
commit 0e95ca90e2bf71802842cab168217fad6b4f958e
Author: Richard Hughes <richard at hughsie.com>
Date: Thu Nov 28 14:46:08 2013 +0000
libcolord: Do not write an invalid dict or mluc data when the
resaving a profile
:100644 100644 e155326... 6a92e61... M lib/colord/cd-icc.c
:100644 100644 a891d8f... 8f87165... M lib/colord/cd-test-private.c
>> That's odd indeed. I'll look into this now. Could it perhaps be that
>> the string is not valid UTF-8 or something like that?
> I think it's pure ASCII...
Right, that was a red-herring. This is fixed by this commit:
commit 93ec8b08d470543b57b0f28ccb14d9ce7ce8820d
Author: Richard Hughes <richard at hughsie.com>
Date: Thu Nov 28 14:56:42 2013 +0000
libcolord: Ensure the version is set when using cd_icc_create_from_edid()
Although this looks trivial as just the version isn't set, it's actually an
important bug as if we write the file we write a v2 file as the
version < 4.0.
:100644 100644 6a92e61... 9de9d6d... M lib/colord/cd-icc.c
:100644 100644 8f87165... 8666d36... M lib/colord/cd-test-private.c
Can you check with master, and if that can write and read the profiles
correctly in xiccd, then I'll cherry pick the important ones to stable
and do a release over the weekend.
Richard.
More information about the colord
mailing list