[compiz] bug in today's git snapshot with maximizing windows
David Reveman
davidr at novell.com
Mon Nov 13 14:00:05 PST 2006
On Sun, 2006-11-12 at 21:31 -0500, Mike Cook wrote:
> On Nov 12, 2006 at 10:33, David Reveman wrote:
> > Thanks, I applied you're patch. I found one issue with the current code
> > though.. We shouldn't use the window position and size to determine if a
> > window should affect the workspace of a output or not. The
> > _NET_WM_STRUT_PARIAL hint contains everything we need to determine if it
> > should affect an output or not.
>
> Ah, good, I wasn't sure the best place to read that...
>
> > I removed the MIN_SANE_AREA stuff as I would like it to be possible to
> > have a zero workarea on some outputs.
> >
> > I changed these things and pushed it out. You should have a look at it
> > and let me know what you think.
> >
> > Thanks,
> >
> > -David
>
> That works great, David. Just one little typo (breaking bottom edge panels):
>
> --- src/screen.c
> +++ src/screen.c
> @@ -2757,7 +2757,7 @@ computeWorkareaForBox (CompScreen *s,
>
> if (x1 < pBox->x2 && x2 > pBox->x1)
> {
> - if (y1 > strutY2)
> + if (y1 < strutY2)
> strutY2 = y1;
> }
> }
Thanks,
-David
More information about the compiz
mailing list