[compiz] Aquamarine: The KDE Window Decorator

[David Reveman]

Looks promising. I had a quick look at the code and I have some
comments/questions...

I can see that you're allocating pixmaps that are the same size or even
a bit larger than the client windows. That adds some pretty nasty memory
consumption, which we can't live with. Have you tried fixing that?
Looking at the code, it seems that it shouldn't be very hard to fix.

I noticed that the default decorations used before any window specific
ones are created are broken. Shouldn't be hard to fix that though.

I can see that the code that changes opacity, brightness.. is updating
the properties on windows directly. You shouldn't do that. You should
send client messages to the WM instead.

Other than these things it looks good. I would much rather support this
than write my own kde-decorator.  I'll try to get the issues I've
pointed out here fixed asap and I'll send you some patches.

btw, I noticed that the copyright notice in each file says that it uses
code of Emerald and KWin. I didn't see a lot of gtk-window-decorator
code in the files I looked at but I know that emerald contains large
chunks of gwd code without gwd's copyright info. If this is actually the
case for aquamarine as well, please add the gwd copyright info.

-David


On Wed, 2006-11-15 at 11:23 +0100, Dennis Kasprzyk wrote:
> Hi,
> 
> I have added compiz support to aquamarine.
> 
> You can download it directly from beryl svn:
> svn co svn://svn.beryl-project.org/beryl/trunk/aquamarine/
> 
> To install:
> ./autogen.sh
> ./configure --enable-debug=full
> ./make
> ./sudo make install
> 
> You can use kcontrol to set the decoration and decoration specific settings.
> 
> You can post bugs to the beryl bugtracker at http://bugs.beryl-project.org .
> Please add your KDE and QT version and a backtrace (if available) to your 
> bugreport.
> 
> Have a lot of fun
> Dennis
> 
> _______________________________________________
> compiz mailing list
> compiz at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/compiz