[compiz] Bug with kde applications and damageWindowRect wrapping...

[Danny Baumann]

Hi,

> > > > If someone can confirm this bug ...
> > > > Run this in an xterm with smart placement method: 
> > > > while true; do konsole & sleep 1; killall konsole; done
> > > > 
> > > > Look at the screen, you should randomly see the bug at konsole window
> > > > mapping...
> > > 
> > > The placement plugin is broken. It shouldn't place windows when they
> > > first appear but instead when we get the map request and before they are
> > > mapped.
> > > 
> > > This bug is only visible in kde apps as kde doesn't support the sync
> > > request protocol.
> > 
> > So you mean something like the attached patch?
> > Let me know if it's correct and it works for you - it does for me ;-)
> 
> Something like that but I think we want this to hook in after we've
> applied the startup properties (event.c:1868) and we'll have to add a
> PlaceWindowProc screen function to do that properly.

This would then be something like the attached patch. However, we still
need to update the decoration on MapRequest before core handles it
(currrently, we do it after core) so w->input has the correct values
when the window is placed. A patch for that is also attached.
Do you agree to that?

Regards,

Danny
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-place-window-proc.diff
Type: text/x-patch
Size: 4696 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/compiz/attachments/20070419/8ba0550c/add-place-window-proc.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: place-fix-decoration.diff
Type: text/x-patch
Size: 779 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/compiz/attachments/20070419/8ba0550c/place-fix-decoration.bin