[compiz] [PATCH] Unbound modifiers and CompNoMask

[David Reveman]

On Sun, 2007-08-05 at 05:21 -0400, Andy Hefner wrote:
> This patch fixes an undesirable behavior in the comparison of modifier
> bits necessary to initiate an action - if the modifier is not configured
> on the user's X server (thus having CompNoMask in its position in
> d->modMask), the comparison always behaves as though the modifier were
> pressed, due to CompNoMask falling outside the REAL_MOD_MASK &
> ~d->ignoredModMask bitmask. This causes actions to be invoked
> inappropriately (for instance, if the user has no keysyms assigned for
> the Super modifier, the zoom plugin can be triggered on unmodified
> scroll wheel events, interfering with normal scrolling).

Good catch.

I added CompNoMask to the REAL_MOD_MASK define, which should take care
of the problem.

Thanks,

-David