[compiz] Re: [PATCH]Application-window switcher, and comments for switcher.c

[David Reveman]

(I assume that you didn't actually want to take this off the list)

On Thu, 2007-02-22 at 11:09 +1100, Christopher Halse Rogers wrote:
> On 2/21/07, David Reveman <davidr at novell.com> wrote:
> > On Thu, 2007-02-15 at 22:23 +1100, Christopher Halse Rogers wrote:
> > > Sorry, this time with the actual patches attached!
> >
> > Great work!
> Thanks :).
> 
> >
> > Wouldn't it make sense to have an enum for the switch type currently
> > used instead of two boolean values (allWindows and appWindows)? It seems
> > that allWindows is currently always FALSE when appWindows is TRUE, which
> > btw is different from the scale plugin where scaling a group will always
> > include group windows from all viewports.
> 
> I considered using an enum, but decided against it.  First, because
> they're not really mutually exclusive - the reason there's not an
> allWindows + appWindows mode is that I'm not quite sure the best way
> to display the windows not on the current viewport (it would probably
> need to use the popup-switcher or change the viewport). 

Isn't how allWindows currently work good enough? Why should allWindows +
appWindows be different then allWindows?

The scale plugin is doing "allWindows + appWindows" for initiate_group
and it seems more useful to me than just doing allWindows.

>  Secondly, I
> wanted my first patch to be minimally invasive, and this seemed the
> best way.

OK, we can put this in first.

> 
> I do hope to extend this a bit further:  I'd like to add an appWindows
> + allWindows mode, and also add some extra animation stuff to the
> app-switcher, so it's easy to distinguish the possible switch-targets
> from the windows from all other applications (I'd be interested in
> hearing feedback as to what the best way to do this would be).  It
> might be worthwhile changing the appWindows/allWindows to a set of
> flags, though.

Do you mean some other animations then the current zoom animation?

- David