[compiz] ubuntu packages patch

[gandalfn]

> > > http://gandalfn.club.fr/ubuntu/compiz-patch/90-fix-no-border-window-shadow.patch
> > > This patch fix white boxes instead of shadows for gnome-panel and other
> > > non-standard windows on AiGLX.
> 
> That patch is funny. It would be nice to track that issue down. Have you
> checked that it's not just a width that is power-of-two that's causing
> problems?
 
While testing with gdb it would seem that the phenomenon appears only
when the width is a modulo of 32 (perhaps a relation with the depth) , I
think it's perhaps a AIGLX xorg bug, unfortunately, I could not
determine from where that came.

> 
> > > 
> > > http://gandalfn.club.fr/ubuntu/compiz-patch/91-workspaces-terminal-keybindings.patch: This patch add workspaces keybindings and launch terminal keybinding.
> 
> I'd like to include this patch. Can you separate the terminal and
> desktop bindings into different patches?
> 
No problemo : 
http://gandalfn.club.fr/ubuntu/compiz-patch/add-workspaces-keybindings.patch
http://gandalfn.club.fr/ubuntu/compiz-patch/add-terminal-keybinding.patch

But I would like notify, calcDesktopIndex function supports only
horizontal workspaces orientation, first element of the
_NET_DESKTOP_LAYOUT atom. It should be improved to support vertical
workspaces orientation.

> btw, we should move the viewport changing actions to the core as well.

> > > 
> > > http://gandalfn.club.fr/ubuntu/compiz-patch/92-gnome-bridge-keybindings-plugin.patch: This patch synchronize metacity and compiz keybindings. It’s add a new keybinding plugin which when compiz is started update its keybindings with those of metacity, and when compiz is launched, it’ll update compiz keybindings when gnome keybindings are updated and vice versa. You can add full gnome keybindings support with this control center patch : http://gandalfn.club.fr/ubuntu/gnome-patch/36-compiz-keybindings-support.patch
> 
> The keybinding bridge plugin is useful, do you want me to create a git
> repo on git.compiz.org for it?

Why not :) it still needs some improvements and it would be the best
mean to make them

> 
> > > 
> > > http://gandalfn.club.fr/ubuntu/compiz-patch/93-focus-user-event.patch: 
> > > This patch allow the active window kept the focus, if user write in it,
> > > when a new window is open, like metacity do.
> 
> We should add full focus prevention support to compiz but I guess this
> might be the most useful part of it so I'm OK with including it now.
> 

I am not sure it's ready for the upstream. It gives the focus in random
way in some cases, it's seem the alone use of UserEvent to determine
focus isn't best solution, I seek other conditions to give it more
functional.

> > > 
> > > http://gandalfn.club.fr/ubuntu/compiz-patch/94-fix-show-managed-window.patch: This patch add in client list window all windows in workspaces, it's fix window show in gnome applet workspace and in gnome applet tasklist.
> 
> I don't think I understand exactly what this patch fixes. Could you
> describe a use case which is causing problems without this patch
> applied?
With gnome task applet or workspace applet, all windows which aren't in
active workspace are hidden except minimized window, it's due in fact
that libwnck get stacked window list for draw or enumerate all windows
in all workspace. When you switch between workspace, say me if wrong,
you map all windows in current workscape and you unmap all others. On
this unmap you set window state to CompWindowStateHiddenMask and wmstate
to IconicState, if you test only state, window stacked list doesn't
include all windows with Hidden state but in these windows you have all
windows in others workspaces and then you don't show them in workspace
applet or tasklist applet. If you include IconicState windows you kept
them in stacked list.

> 
> I assume that you're the author of all these patches and you're OK with
> me including the ones I'm interested in upstream. Let me know if that's
> not the case.
> 
Yes, I'm author of these patches, you can use them how do you want ;)
i'm sure you improve them better can i do. Otherwise I include a fedora
patch in ubuntu deb which restart compiz on crash using session manager,
in this case i don't know author but it's work very well:
http://gandalfn.club.fr/ubuntu/compiz-patch/06-fedora-restart-on-crash.patch

> Thanks,
> 
> -David
> 
> �
> 
Nicolas
-- 
gandalfn <gandalfn at club-internet.fr>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/compiz/attachments/20070110/02d27b93/attachment.pgp