[compiz] Re: [PATCH] dbus list option as array - was: DBus setting options broken

David Reveman davidr at novell.com
Fri Jan 26 15:00:01 PST 2007


On Fri, 2007-01-26 at 20:22 +0000, Mike Dransfield wrote:
> David Reveman wrote:
> >> I think the correct solution would be to allow
> >> the dbus plugin to receive arrays and convert them
> >> to lists internally.  I can have a look at doing this
> >> if you do not mind.
> >>     
> >
> > yes, list options should be sent as arrays. i definitely don't mind,
> > please look at it.
> >   
> 
> Here is a small patch that means lists options have
> to be sent as arrays, it should make it easier for
> language bindings.
> 
> To send an array using dbus-send, use this syntax
> 
> array:string:'foo','bar'
> 
> It should work with all the datatypes, I haven't tested
> it but I see no reason why it shouldn't.
> 
> Zero length arrays are fine so you can unset a list option
> by using this as the value
> 
> array:string:
> 
> This patch is for the set option only, I couldn't see any
> other place where an array needs to be converted to a list.

Looks good. I updated the example in comment above the function that you
changed and pushed it out.

Thanks,

- David



More information about the compiz mailing list