[compiz] [PATCH] Always use mipmaps in cube plugin
David Reveman
davidr at novell.com
Fri Jul 27 14:14:45 PDT 2007
On Wed, 2007-06-27 at 01:35 +0200, Bartosz Taudul wrote:
> Currently, the cube plugin uses mipmapping only when cube is unfolded.
> When the cube is rotated, mipmaps are not used, which leads to ugly look
> of textures.
Yeah, using mipmap filtering in those cases should be optional. I've
avoided it so far because it adds a significant overhead compared to
bilinear filtering as the mipmap levels needs to be updated every time a
texture changes.
>
> The attached patch fixes this. This leads to another kind of artifacts,
> which are fixable with anisotropic filtering.
>
> http://team.pld-linux.org/~wolf/aniso.png
> The leftmost image is the current state of cube plugin. The center image
> is with mipmaps enabled. The rightmost is with mipmaps and anisotropic
> filtering.
Sure, anisotropic filtering should be added as well if we allow mipmaps
to be used in cases where it makes a difference. So far mipmap filtering
have only been used in cases where it doesn't make any difference.
It might make sense to add this as a global filter method instead. E.g.
used automatically when core texture_filter is set "Best".
-David
More information about the compiz
mailing list