[compiz] [PATCH] Grab state & Last state remembering

[Danny Baumann]

Hi,

> > - Remembering of the last window state inside the state change notify
> > This is useful for properly tracking down the window state changes (e.g.
> > has the window been maximized in that state change?). In Beryl, we added
> > a variable lastState into CompWindow, which is updated inside core's
> > stateChangeNotify. The attached last-window-state.patch brings that
> > behaviour to Compiz.
> 
> I've applied the patch. However, all code that cause a change to the
> state should be modified so that a mask of changed bits can be passed to
> the state change notify function instead. This lastState variable
> shouldn't have to exist.

In the attached patch, I've modified your recently added function
changeWindowState to make the passing of a changed state bit mask
easier:
- Don't modify w->state outside of changeWindowState
- Issue the state change notify only if the state was changed

I think with these changes, only the actual bitmask passing is missing.
What do you think?

Regards,

Danny
-------------- next part --------------
A non-text attachment was scrubbed...
Name: window-state.diff
Type: text/x-patch
Size: 4154 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/compiz/attachments/20070306/8caa0aea/window-state.bin