AW: Re: [compiz] [PATCH] minimize doesn't respect "no core instance" flag

[Danny Baumann]

Hi,

Let me ask in a more general way:

A plugin wants to hide windows by preventing their drawing - that's all group wants to do. 
What's the correct way to do that? From my understanding, that's NO_CORE_INSTANCE_MASK. If that's not true, what's the exact meaning of that flag?
Another way to do that would be to just return from paintWindow instead of calling the next plugin, but I think that's a bad solution.

Regards,
Danny

----- Ursprüngliche Nachricht -----
Von: "David Reveman" <davidr at novell.com>
An: "Danny Baumann" <dannybaumann at web.de>
Cc: compiz at lists.freedesktop.org
Gesendet: 09.03.2007 14:13
Betreff: Re: [compiz] [PATCH] minimize doesn't respect "no core instance"	flag

On Wed, 2007-03-07 at 14:39 +0100, Danny Baumann wrote:
> Hi,
> 
> In current git, minimize doesn't respect the
> PAINT_WINDOW_NO_CORE_INSTANCE_MASK flag set by other plugins. I noticed
> that especially in group: Tabbed windows are hidden by setting
> PAINT_WINDOW_NO_CORE_INSTANCE_MASK. When these windows are minimized
> together with their group, minimize draws its animation regardless if
> that flag is set or not; with the effect of the hidden windows appearing
> during the time of animation.
> I've attached a patch which makes minimize respect that flag; however,
> I'm not completely sure if that is the best way to do it or if it would
> be better to do the animation drawing inside of drawWindow().
> 
> What do you think?

Plugins are not supposed to look at the
PAINT_WINDOW_NO_CORE_INSTANCE_MASK flag. It's supposed to be a
write-only flag for plugins.

I'm not sure what's the best solution is here as I don't know exactly
how the group plugin works. Checking if the
PAINT_WINDOW_NO_CORE_INSTANCE_MASK flag is preset is definitely not the
correct solution though.

- David