[compiz] [PATCH] Vertical/Horizontal maximization ingtk-window-decorator

[David Reveman]

On Fri, 2007-03-30 at 13:04 +0200, Cedric wrote:
>         You would prefer if you avoid duplicating
>         
>         if (d->button_states[BUTTON_MAX] ==
>         BUTTON_EVENT_ACTION_STATE) 
>         {
>         
>         and
>         
>         d->button_states[BUTTON_MAX] &= ~PRESSED_EVENT_WINDOW;
>         
>         
>         Do you think we should be concerned about making this optional
>         or do you
>         think it's functionality that everyone wants, even grandma? 
>         
>         - David
> 
> 
> Here a new version, i think it's  good but may be wrong. Not sure if
> testing d->button_states[BUTTON_MAX] before xevent->xbutton.button can
> introduce some issues...

No, but I included the "if (xevent->xbutton.button <= 3)" check to make
sure things are consistent.

> 
> Why making this optional?
> From a user point of view, it doesn't affect how normal maximization
> work.

Yes, but some poor bastard might sometimes be using the wrong button to
maximize windows and now it will suddenly maximize the window in some
weird way they've never seen before instead of doing nothing.

> 
> But if you think we should add this as an option, i will change my
> patch.

Lets leave it for later when someone actually complains. I've applied
you're patch.

Thanks,

- David