[compiz] Bug in otherScreenGrabExist?

[Mike Dransfield]

David Reveman wrote:
> On Fri, 2007-05-04 at 00:49 +0100, Mike Dransfield wrote:
>   
>> I am fairly sure that this is just a bug in the codes logic, but
>> I thought I should check first
>>     
>
> hm, I think the code is currently doing the correct thing.
>   

In that case I think this patch is more appropriate ;)

Do you think it is clear and correct?

>   
>> I noticed that the function was always returning true if only
>> one grab is checked for (maybe other cases too)
>>     
>
> I fail to see why. Can you provide some more details of what you're
> doing?
>
> - David
>
>   
-------------- next part --------------
diff --git a/include/compiz.h b/include/compiz.h
index 8a0edfa..d2f3c2d 100644
--- a/include/compiz.h
+++ b/include/compiz.h
@@ -655,6 +655,7 @@ typedef Bool (*ImageToFileProc) (CompDisplay *display,
 #define NOTIFY_DELETE_MASK (1 << 1)
 #define NOTIFY_MOVE_MASK   (1 << 2)
 #define NOTIFY_MODIFY_MASK (1 << 3)
+#define NOTIFY_OPEN_MASK   (1 << 4)
 
 typedef void (*FileWatchCallBackProc) (const char *name,
 				       void	  *closure);
@@ -2057,6 +2058,10 @@ removeScreenGrab (CompScreen *s,
 		  int	     index,
 		  XPoint     *restorePointer);
 
+/* otherScreenGrabExist takes a series of strings terminated by a NULL.
+   It returns TRUE if a grab exists but it is NOT held by one of the
+   plugins listed, returns FALSE otherwise. */
+
 Bool
 otherScreenGrabExist (CompScreen *s, ...);