[compiz] core improvements

Kristian Høgsberg krh at bitplanet.net
Fri Sep 7 15:04:17 PDT 2007


On 9/7/07, Kristian Høgsberg <krh at bitplanet.net> wrote:
> On 9/7/07, David Reveman <davidr at novell.com> wrote:
> ...
> > - Object model
> >
> > We need to easily be able to create new types of objects that plugins
> > can keep track of and add options to without breaking the API or even
> > the ABI.
> >
> > The initial part of this is already in head. The object system I've
> > added is very simple but still sufficient. It allows us to add new core
> > objects without having to update any plugins.
> >
> > Next step is to add an interface that will allow plugins to add their
> > own type of objects. This is a simple addition to the current object
> > system and you can expect it to land in head shortly.
>
> I browsed the patch, and it look mostly good, but I wondered why you
> decided to go for a 'type' integer instead of the more custom 'class'
> pointer (or objectInfo pointer).  Then you could just do
>
> char *
> compObjectName (CompObject *object)
> {
>  return (*nameObject->ObjectInfo) (object);
> }

Oops, this should have been

  (* object->objectInfo->nameObject) (object)

Kristian


More information about the compiz mailing list