[compiz] CompRect modification

[Sam Spilsbury]

On Mon, Mar 2, 2009 at 4:40 PM, Danny Baumann <dannybaumann at web.de> wrote:
> Hi,
>
>> >         > Me and Dennis Kasprzyk changed CompRect to be more intuitive
>> >         and easily
>> >         > replace XRectangle use.
>> >         >
>> >         > This patch changes CompRect and whole Core.
>> >         >
>> >         > Thanks for attention.
>>
>> Personally, I'd like to see x1/y1/x2/y2 instead of
>> left/top/right/bottom. The reason is that while left etc. is the
>> somewhat clearer term, x1 etc. is the more commonly used term for
>> defining rectangles.
>
> Oh, and what I forgot: Wouldn't it be a good idea to derive
> CompWindow::Geometry from CompRect? After all, CompWindow::Geometry is
> just the window rectangle + border size handling.
>
> (and on a slightly related question, wouldn't it also be a good idea to
> add a function that returns a CompRect with window size including frame
> to CompWindow?)
>
> Regards,
>
> Danny
>
>


I don't know if such a function exists. But it would be nice to add
functions that return a BOX, Box, XRectangle and Region. We need to
use these for X.org functions.

Also, doesn't eduardo's patch cover place.cpp?

Regards,

Sam.


-- 
Sam Spilsbury