[compiz] Two patches for Snap

[Jay Catherwood]

On Fri, Jun 18, 2010 at 2:26 PM, Sam Spilsbury <smspillaz at gmail.com> wrote:

> On 6/18/10, Jay Catherwood <jay.catherwood at gmail.com> wrote:
> > (1) The snap to windows checkbox in ccsm has no effect because Snap
> treats
> > any window with struts as an edge, and all windows have struts.
>
> Didn't apply this one. w->struts () should return NULL if there are no
> struts. If all windows have struts then this is a bug in core
>

All right. CompWindow::updateStruts does give all windows struts. I turned
that off and the snapping problem is fixed for me. Patch is attached.


>
> > (2) Windows don't snap to the left edge because it has been erased. The
> > right edge doesn't seem to get erased because it is slightly offscreen,
> so I
> > did the same thing with the left. I don't know if that is exactly the
> right
> > solution, but at least it works.
>
> Applied,
>

It turns out this bug was an artifact of all windows having struts. I think
you can revert this if you apply the patch to updateStruts.

Thanks,
Jay
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/compiz/attachments/20100618/affc487e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: no-universal-struts.patch
Type: text/x-patch
Size: 294 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/compiz/attachments/20100618/affc487e/attachment.bin>