[ConsoleKit] Review for bug 26055

[Ray Strode]

Hi,

On Tue, May 18, 2010 at 3:17 AM, Halton Huo <halton.huo at gmail.com> wrote:

> Can somebody review patch for
> https://bugs.freedesktop.org/show_bug.cgi?id=26055?
There's certainly nothing wrong with the concept, but the patch has a
few issues that need to be fixed.

1) Internal functions have to have return types and be declared static
2) Functions have to be in all lower case
3) presumably you need to link libscf in?
4) you check for HAVE_SYS_VT_H in one place, HAVE_SCF in another.  I
have vt.h on linux and i don't have those functions, so you probably
shouldn't check for HAVE_VT_H.

> I push this change to master accidentally when I push change in the
> multi-seat branch today.
>
> If the above fix is okay, I can skip reverting this change. Otherwise, I
> will revert it out.
You probably need to either revert it or get fixes in quickly.

--Ray