[CREATE] [Mypaint-discuss] Layer mode enhancement to the dev. branch

[Andrew Chadwick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

[Cc: CREATE, since the OpenRaster spec looks wrong. Reply-to: set
because this is otherwise mostly a MyPaint development issue. Please
direct your responses to the appropriate list!]

On 22/09/11 17:28, Martin Renold wrote:
> Other minor points:
> 
> +        # FIXME: layer modes must be managed in some module or class, and should not be written hard coded.  
> 
> Nah, I think it's okay to use a simple string, as long as only one string is
> allowed (not several variants) and as long as this string is not displayed
> in the GUI (it should be translatable, maybe make another dict for this). 
> And please use "over", not "normal" in the code.  "normal" is good for
> displaying to the user, but not internally.  And variants like this:
> 
> +        elif mode == 'color-dodge' or mode == 'dodge':
> 
> should not be neccessary, better translate them at load-time.

Working on these and getting something we can merge neatly at
http://gitorious.org/~achadwick/mypaint/achadwick-mypaint/commits/sigetch-layer-blending-formerge1
(note: this is a cut-up of sigetch's branch, and has been rebased
against master)

Assume it's OK to work internally using the svg:$MODE strings and
translate at the gui level? Basically, store e.g. "svg:color-burn" as
the composite-op attribute's value as described at
http://create.freedesktop.org/wiki/OpenRaster/Layers_Stack_Specification#layer_element
? I'm *ignoring* the example, which seems plain incorrect according to
the spec: this should probably be fixed.

>> * Workflow: not sure about splitting undo stack strokes at the end of
>> input strokes. This may be more natural for people, but are there any
>> potential technical tripfalls? Maxy? Jon?
> 
> No go.

Not included in the "-formerge1" branch above :) Might be nice to have
as a prefs setting though, maybe.

- -- 
Andrew Chadwick
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk580RQACgkQo3CEnCcHJXfrNwCfRVm495vG6b7qqmhuUIz+cI4h
0BEAnAnaKD5yFwSW2+ymVdaDXTwJFjL/
=6OkR
-----END PGP SIGNATURE-----