dbus/dbus/test [POSSIBLY UNSAFE]

johnp freedesktop-cvs-commits at pdx.freedesktop.org
Sat Apr 24 01:25:16 EST 2004


CVS commit by johnp: 

* Fixed buffer overflow cause by not incrementing 
the times_we_did_each_thing counter array to reflect
the number of random mutation functions we have.


  M +4 -3      dbus/dbus/test/break-loader.c   1.12 [POSSIBLY UNSAFE: printf]


--- dbus/dbus/test/break-loader.c  #1.11:1.12
@@ -455,5 +455,5 @@ randomly_change_one_type (const DBusStri
 }
 
-static int times_we_did_each_thing[6] = { 0, };
+static int times_we_did_each_thing[7] = { 0, };
 
 static void
@@ -742,5 +742,5 @@ main (int    argc,
         }
 
-      printf ("  did %d random mutations: %d %d %d %d %d %d\n",
+      printf ("  did %d random mutations: %d %d %d %d %d %d %d\n",
               _DBUS_N_ELEMENTS (times_we_did_each_thing),
               times_we_did_each_thing[0],
@@ -749,5 +749,6 @@ main (int    argc,
               times_we_did_each_thing[3],
               times_we_did_each_thing[4],
-              times_we_did_each_thing[5]);
+              times_we_did_each_thing[5],
+              times_we_did_each_thing[6]);
       
       printf ("Found %d failures with seed %u stored in %s\n",





More information about the dbus-commit mailing list