dbus/glib dbus-gvalue.c,1.27,1.28

Rob McQueen robot101 at kemper.freedesktop.org
Fri Apr 28 13:36:58 PDT 2006


Update of /cvs/dbus/dbus/glib
In directory kemper:/tmp/cvs-serv10449/glib

Modified Files:
	dbus-gvalue.c 
Log Message:
2005-04-28  Robert McQueen  <robot101 at debian.org>

	* glib/dbus-gvalue.c: Patch from Jakub Stachowski to fix a leak in
	generating struct signatures. Fixes bug #6083.

Index: dbus-gvalue.c
===================================================================
RCS file: /cvs/dbus/dbus/glib/dbus-gvalue.c,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -d -r1.27 -r1.28
--- dbus-gvalue.c	16 Feb 2006 00:43:41 -0000	1.27
+++ dbus-gvalue.c	28 Apr 2006 20:36:56 -0000	1.28
@@ -392,10 +392,13 @@
       size = dbus_g_type_get_struct_size (gtype);
       sig = g_string_sized_new (size+2); /*some sensible starting size*/
       g_string_assign (sig, DBUS_STRUCT_BEGIN_CHAR_AS_STRING);
-      for (i=0; i < size; i++)
+      for (i = 0; i < size; i++)
         {
-          g_string_append (sig, _dbus_gtype_to_signature (
-              dbus_g_type_get_struct_member_type (gtype, i)));
+          gchar *subsig;
+          subsig = _dbus_gtype_to_signature (
+              dbus_g_type_get_struct_member_type (gtype, i));
+          g_string_append (sig, subsig);
+          g_free (subsig);
         }
       g_string_append (sig, DBUS_STRUCT_END_CHAR_AS_STRING);
       ret = g_string_free (sig, FALSE);



More information about the dbus-commit mailing list