dbus/glib dbus-gproxy.c,1.46,1.47

Ross Burton ross at kemper.freedesktop.org
Mon Jun 12 07:22:50 PDT 2006


Update of /cvs/dbus/dbus/glib
In directory kemper:/tmp/cvs-serv32690/glib

Modified Files:
	dbus-gproxy.c 
Log Message:
2006-06-12  Ross Burton  <ross at openedhand.com>

	* glib/dbus-gproxy.c:
	Don't leak a GArray when firing signals (thank Rob Taylor for review).


Index: dbus-gproxy.c
===================================================================
RCS file: /cvs/dbus/dbus/glib/dbus-gproxy.c,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -d -r1.46 -r1.47
--- dbus-gproxy.c	28 Apr 2006 21:11:28 -0000	1.46
+++ dbus-gproxy.c	12 Jun 2006 14:22:48 -0000	1.47
@@ -1625,6 +1625,7 @@
   char *name;
   GQuark q;
   DBusGProxyPrivate *priv = DBUS_G_PROXY_GET_PRIVATE(proxy);
+  GArray *msg_gsignature = NULL;
 
   g_return_if_fail (!DBUS_G_PROXY_DESTROYED (proxy));
 
@@ -1645,7 +1646,6 @@
   if (q != 0)
     {
       GArray *gsignature;
-      GArray *msg_gsignature;
       guint i;
       
       gsignature = g_datalist_id_get_data (&priv->signal_signatures, q);
@@ -1672,6 +1672,8 @@
 
  out:
   g_free (name);
+  if (msg_gsignature)
+    g_array_free (msg_gsignature, TRUE);
   return;
  mismatch:
 #if 0



More information about the dbus-commit mailing list