dbus/test test-service.c,1.26,1.27 test-shell-service.c,1.3,1.4

Havoc Pennington hp at kemper.freedesktop.org
Sun Oct 1 10:21:05 PDT 2006


Update of /cvs/dbus/dbus/test
In directory kemper:/tmp/cvs-serv7150/test

Modified Files:
	test-service.c test-shell-service.c 
Log Message:
2006-10-01  Havoc Pennington  <hp at redhat.com>

	* test/test-service.c (path_message_func): remove broken extra
	unref that was hidden by the bugs in dbus-connection.c/dbus-bus.c

	* test/test-shell-service.c (path_message_func): same fix
	
	* dbus/dbus-connection.c
	(_dbus_connection_get_dispatch_status_unlocked): break up the
	function a little for clarity and fix the notification of
	dbus-bus.c to not require dispatch to be complete

	* dbus/dbus-connection.c (dbus_connection_unref): improve the
	warning when you try to finalize an open connection.
	


Index: test-service.c
===================================================================
RCS file: /cvs/dbus/dbus/test/test-service.c,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -d -r1.26 -r1.27
--- test-service.c	6 Sep 2006 22:00:07 -0000	1.26
+++ test-service.c	1 Oct 2006 17:21:03 -0000	1.27
@@ -3,7 +3,7 @@
 
 static DBusLoop *loop;
 static dbus_bool_t already_quit = FALSE;
-static dbus_bool_t hello_from_self_reply_recived = FALSE;
+static dbus_bool_t hello_from_self_reply_received = FALSE;
 
 static void
 quit (void)
@@ -54,7 +54,7 @@
   if (type == DBUS_MESSAGE_TYPE_METHOD_RETURN)
     {
       const char *s;
-      printf ("Reply from HelloFromSelf recived\n");
+      printf ("Reply from HelloFromSelf received\n");
      
       if (!dbus_message_get_args (echo_message,
                               &error,
@@ -108,9 +108,9 @@
       dbus_error_free (&error);
     }
   else
-     _dbus_assert_not_reached ("Unexpected message recived\n");
+     _dbus_assert_not_reached ("Unexpected message received\n");
 
-  hello_from_self_reply_recived = TRUE;
+  hello_from_self_reply_received = TRUE;
   
   dbus_message_unref (reply);
   dbus_message_unref (echo_message);
@@ -243,7 +243,6 @@
                                         "org.freedesktop.TestSuite",
                                         "Exit"))
     {
-      dbus_connection_unref (connection);
       quit ();
       return DBUS_HANDLER_RESULT_HANDLED;
     }
@@ -286,7 +285,7 @@
                                         "HelloFromSelf"))
     {
         DBusMessage *reply;
-        printf ("Recived the HelloFromSelf message\n");
+        printf ("Received the HelloFromSelf message\n");
         
         reply = dbus_message_new_method_return (message);
         if (reply == NULL)

Index: test-shell-service.c
===================================================================
RCS file: /cvs/dbus/dbus/test/test-shell-service.c,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- test-shell-service.c	6 Sep 2006 22:00:07 -0000	1.3
+++ test-shell-service.c	1 Oct 2006 17:21:03 -0000	1.4
@@ -85,7 +85,6 @@
                                         "org.freedesktop.TestSuite",
                                         "Exit"))
     {
-      dbus_connection_unref (connection);
       quit ();
       return DBUS_HANDLER_RESULT_HANDLED;
     }



More information about the dbus-commit mailing list