dbus ChangeLog,1.1140,1.1141 configure.in,1.184,1.185
John (J5) Palmieri
johnp at redhat.com
Wed Oct 11 12:15:18 PDT 2006
On Wed, 2006-10-11 at 20:55 +0200, Thiago Macieira wrote:
> John (J5) Palmieri wrote:
> >On Wed, 2006-10-11 at 20:08 +0200, Thiago Macieira wrote:
> >> John Palmieri wrote:
> >> >+ [AC_TRY_RUN([
> >> >+#include <sys/types.h>
> >> >+#include <dirent.h>
> >> >+int main () {
> >> >+ DIR *dirp;
> >> >+ dirp = opendir(".");
> >> >+ dirfd(dirp);
> >> >+ closedir(dirp);
> >> >+}],
> >>
> >> Do you need to run this program to test the dirfd availability?
> >
> >For freebsd you do since it is a macro and not a function. Of course we
> >could do an AC_CHECK_FUNCS (dirp) and if that fails run the program. I
> >don't know autofoo all that well though.
>
> I meant: isn't compiling (AC_TRY_COMPILE) enough? Do you need to actually
> *run* the compiled code?
>
> In special, you're not returning anything from main, so the test is
> actually returning whether closedir succeeded or not.
True. AC_TRY_COMPILE should be enough. I will change.
--
John (J5) Palmieri <johnp at redhat.com>
More information about the dbus-commit
mailing list