dbus/bus activation.c, 1.44, 1.45 connection.c, 1.62, 1.63 desktop-file.c, 1.12, 1.13 driver.c, 1.77, 1.78 test-main.c, 1.21, 1.22

John Palmieri johnp at kemper.freedesktop.org
Tue Sep 5 17:14:08 PDT 2006


Update of /cvs/dbus/dbus/bus
In directory kemper:/tmp/cvs-serv16495/bus

Modified Files:
	activation.c connection.c desktop-file.c driver.c test-main.c 
Log Message:
* doc/TODO, various source files: Audited todo's and FIXME's and
  prepended the ones we should be looking at with 1.0.  Those
  prepended with 1.0? need clerification or might not be needed
  for 1.0


Index: activation.c
===================================================================
RCS file: /cvs/dbus/dbus/bus/activation.c,v
retrieving revision 1.44
retrieving revision 1.45
diff -u -d -r1.44 -r1.45
--- activation.c	10 Aug 2006 20:09:43 -0000	1.44
+++ activation.c	6 Sep 2006 00:14:06 -0000	1.45
@@ -1017,7 +1017,7 @@
 }
 
 /**
- * FIXME @todo the error messages here would ideally be preallocated
+ * FIXME @todo 1.0? the error messages here would ideally be preallocated
  * so we don't need to allocate memory to send them.
  * Using the usual tactic, prealloc an OOM message, then
  * if we can't alloc the real error send the OOM error instead.

Index: connection.c
===================================================================
RCS file: /cvs/dbus/dbus/bus/connection.c,v
retrieving revision 1.62
retrieving revision 1.63
diff -u -d -r1.62 -r1.63
--- connection.c	10 Feb 2006 21:44:15 -0000	1.62
+++ connection.c	6 Sep 2006 00:14:06 -0000	1.63
@@ -183,7 +183,7 @@
       bus_matchmaker_disconnected (matchmaker, connection);
     }
   
-  /* Drop any service ownership. FIXME Unfortunately, this requires
+  /* Drop any service ownership. FIXME 1.0? Unfortunately, this requires
    * memory allocation and there doesn't seem to be a good way to
    * handle it other than sleeping; we can't "fail" the operation of
    * disconnecting a client, and preallocating a broadcast "service is

Index: desktop-file.c
===================================================================
RCS file: /cvs/dbus/dbus/bus/desktop-file.c,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -d -r1.12 -r1.13
--- desktop-file.c	8 Aug 2006 23:29:03 -0000	1.12
+++ desktop-file.c	6 Sep 2006 00:14:06 -0000	1.13
@@ -772,7 +772,7 @@
 
   *val = _dbus_strdup (raw);
 
-  /* FIXME we don't distinguish "key not found" from "out of memory" here,
+  /* FIXME 1.0 we don't distinguish "key not found" from "out of memory" here,
    * which is broken.
    */
   if (*val == NULL)

Index: driver.c
===================================================================
RCS file: /cvs/dbus/dbus/bus/driver.c,v
retrieving revision 1.77
retrieving revision 1.78
diff -u -d -r1.77 -r1.78
--- driver.c	14 Jul 2006 01:17:59 -0000	1.77
+++ driver.c	6 Sep 2006 00:14:06 -0000	1.78
@@ -1734,7 +1734,7 @@
 void
 bus_driver_remove_connection (DBusConnection *connection)
 {
-  /* FIXME Does nothing for now, should unregister the connection
+  /* FIXME 1.0 Does nothing for now, should unregister the connection
    * with the bus driver.
    */
 }

Index: test-main.c
===================================================================
RCS file: /cvs/dbus/dbus/bus/test-main.c,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -d -r1.21 -r1.22
--- test-main.c	3 Nov 2004 16:38:35 -0000	1.21
+++ test-main.c	6 Sep 2006 00:14:06 -0000	1.22
@@ -94,7 +94,7 @@
   _dbus_string_init_const (&test_data_dir, dir);
 
 #if 0
-  /* FIXME this is disabled because of thread bugs that need fixing... */
+  /* FIXME 1.0 this is disabled because of thread bugs that need fixing... */
   if (!_dbus_threads_init_debug ())
     die ("initializing debug threads");
 #endif



More information about the dbus-commit mailing list