dbus/dbus dbus-auth.c, 1.47, 1.48 dbus-connection.c, 1.126,
1.127 dbus-keyring.c, 1.31, 1.32 dbus-marshal-basic.c, 1.28,
1.29 dbus-marshal-recursive.h, 1.30, 1.31 dbus-message-util.c,
1.9, 1.10 dbus-pending-call.c, 1.18, 1.19 dbus-server.c, 1.43,
1.44 dbus-sysdeps-util-unix.c, 1.1, 1.2 dbus-sysdeps.c, 1.109, 1.110
John Palmieri
johnp at kemper.freedesktop.org
Tue Sep 5 17:14:08 PDT 2006
Update of /cvs/dbus/dbus/dbus
In directory kemper:/tmp/cvs-serv16495/dbus
Modified Files:
dbus-auth.c dbus-connection.c dbus-keyring.c
dbus-marshal-basic.c dbus-marshal-recursive.h
dbus-message-util.c dbus-pending-call.c dbus-server.c
dbus-sysdeps-util-unix.c dbus-sysdeps.c
Log Message:
* doc/TODO, various source files: Audited todo's and FIXME's and
prepended the ones we should be looking at with 1.0. Those
prepended with 1.0? need clerification or might not be needed
for 1.0
Index: dbus-auth.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-auth.c,v
retrieving revision 1.47
retrieving revision 1.48
diff -u -d -r1.47 -r1.48
--- dbus-auth.c 30 Nov 2005 19:32:26 -0000 1.47
+++ dbus-auth.c 6 Sep 2006 00:14:06 -0000 1.48
@@ -1925,7 +1925,7 @@
if (!_dbus_string_move (&line, i, &args, 0))
goto out;
- /* FIXME we should probably validate that only the allowed
+ /* FIXME 1.0 we should probably validate that only the allowed
* chars are in the command name
*/
@@ -2397,7 +2397,7 @@
* the peer. If no encoding was negotiated, just copies the bytes (you
* can avoid this by checking _dbus_auth_needs_decoding()).
*
- * @todo We need to be able to distinguish "out of memory" error
+ * @todo 1.0? We need to be able to distinguish "out of memory" error
* from "the data is hosed" error.
*
* @param auth the auth conversation
Index: dbus-connection.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-connection.c,v
retrieving revision 1.126
retrieving revision 1.127
diff -u -d -r1.126 -r1.127
--- dbus-connection.c 16 Aug 2006 22:30:15 -0000 1.126
+++ dbus-connection.c 6 Sep 2006 00:14:06 -0000 1.127
@@ -444,7 +444,7 @@
* @param connection the connection.
* @param link the list node and message to queue.
*
- * @todo This needs to wake up the mainloop if it is in
+ * @todo 1.0? This needs to wake up the mainloop if it is in
* a poll/select and this is a multithreaded app.
*/
void
@@ -863,9 +863,10 @@
_dbus_pending_call_set_timeout_added_unlocked (pending, FALSE);
}
- /* FIXME this is sort of dangerous and undesirable to drop the lock here, but
- * the pending call finalizer could in principle call out to application code
- * so we pretty much have to... some larger code reorg might be needed.
+ /* FIXME 1.0? this is sort of dangerous and undesirable to drop the lock
+ * here, but the pending call finalizer could in principle call out to
+ * application code so we pretty much have to... some larger code reorg
+ * might be needed.
*/
_dbus_connection_ref_unlocked (connection);
_dbus_pending_call_unref_and_unlock (pending);
@@ -2693,7 +2694,7 @@
if (!_dbus_connection_get_is_connected_unlocked (connection))
{
- /* FIXME send a "DBUS_ERROR_DISCONNECTED" instead, just to help
+ /* FIXME 1.0 send a "DBUS_ERROR_DISCONNECTED" instead, just to help
* programmers understand what went wrong since the timeout is
* confusing
*/
Index: dbus-keyring.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-keyring.c,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -d -r1.31 -r1.32
--- dbus-keyring.c 30 Nov 2005 19:32:26 -0000 1.31
+++ dbus-keyring.c 6 Sep 2006 00:14:06 -0000 1.32
@@ -44,7 +44,7 @@
* by a single server instance for a fixed period of time, then
* discarded). Also, the keys are not sent over the wire.
*
- * @todo there's a memory leak on some codepath in here, I saw it once
+ * @todo 1.0? there's a memory leak on some codepath in here, I saw it once
* when running make check - probably some specific initial cookies
* present in the cookie file, then depending on what we do with them.
*/
Index: dbus-marshal-basic.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-marshal-basic.c,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -d -r1.28 -r1.29
--- dbus-marshal-basic.c 14 Aug 2006 19:11:35 -0000 1.28
+++ dbus-marshal-basic.c 6 Sep 2006 00:14:06 -0000 1.29
@@ -598,7 +598,8 @@
* If you ask for #DBUS_TYPE_DOUBLE you will get a "const double*" back
* and the "value" argument should be a "const double**" and so on.
*
- * @todo we aren't using this function (except in the test suite)
+ * @todo 1.0 we aren't using this function (except in the test suite)
+ * add #ifdefs around it
*
* @param str the string to read from
* @param pos position to read from
@@ -1359,7 +1360,8 @@
/**
* If in verbose mode, print a block of binary data.
*
- * @todo right now it prints even if not in verbose mode
+ * @todo 1.0 right now it prints even if not in verbose mode
+ * check for verbose mode and return if not
*
* @param data the data
* @param len the length of the data
Index: dbus-marshal-recursive.h
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-marshal-recursive.h,v
retrieving revision 1.30
retrieving revision 1.31
diff -u -d -r1.30 -r1.31
--- dbus-marshal-recursive.h 11 May 2005 18:07:22 -0000 1.30
+++ dbus-marshal-recursive.h 6 Sep 2006 00:14:06 -0000 1.31
@@ -46,7 +46,7 @@
* and getting the values should be fast and not involve all this type
* reader nonsense.
*
- * @todo DBusTypeMark isn't used right now and probably won't be, we should delete it
+ * @todo 1.0 DBusTypeMark isn't used right now and probably won't be, we should delete it
*/
struct DBusTypeMark
{
Index: dbus-message-util.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-message-util.c,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -d -r1.9 -r1.10
--- dbus-message-util.c 9 Apr 2005 23:50:58 -0000 1.9
+++ dbus-message-util.c 6 Sep 2006 00:14:06 -0000 1.10
@@ -40,10 +40,6 @@
* basic type may be read with this function. See
* dbus_message_get_args() for more details.
*
- * @todo this is static for now because there's no corresponding
- * iter_append_args() and I'm not sure we need this function to be
- * public since dbus_message_get_args() is what you usually want
- *
* @param iter the message iterator
* @param error error to be filled in on failure
* @param first_arg_type the first argument type
Index: dbus-pending-call.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-pending-call.c,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -d -r1.18 -r1.19
--- dbus-pending-call.c 5 Sep 2006 22:05:12 -0000 1.18
+++ dbus-pending-call.c 6 Sep 2006 00:14:06 -0000 1.19
@@ -624,7 +624,7 @@
* If the pending call is already completed, this function returns
* immediately.
*
- * @todo when you start blocking, the timeout is reset, but it should
+ * @todo 1.0? when you start blocking, the timeout is reset, but it should
* really only use time remaining since the pending call was created.
*
* @param pending the pending call
Index: dbus-server.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-server.c,v
retrieving revision 1.43
retrieving revision 1.44
diff -u -d -r1.43 -r1.44
--- dbus-server.c 16 Aug 2006 22:30:15 -0000 1.43
+++ dbus-server.c 6 Sep 2006 00:14:06 -0000 1.44
@@ -471,7 +471,7 @@
* dbus_server_set_watch_functions() should be called
* immediately to render the server fully functional.
*
- * @todo error messages on bad address could really be better.
+ * @todo 1.0? error messages on bad address could really be better.
* DBusResultCode is a bit limiting here.
*
* @param address the address of this server.
@@ -558,7 +558,7 @@
goto out;
}
- /* FIXME - we will unconditionally unlink() the path if
+ /* FIXME 1.0 - we will unconditionally unlink() the path if
* we don't support abstract namespace. unlink() does
* not follow symlinks, but would like independent
* confirmation this is safe enough. See also
Index: dbus-sysdeps-util-unix.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-sysdeps-util-unix.c,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- dbus-sysdeps-util-unix.c 30 Aug 2006 01:06:28 -0000 1.1
+++ dbus-sysdeps-util-unix.c 6 Sep 2006 00:14:06 -0000 1.2
@@ -252,7 +252,7 @@
/* setgroups() only works if we are a privileged process,
* so we don't return error on failure; the only possible
* failure is that we don't have perms to do it.
- * FIXME not sure this is right, maybe if setuid()
+ * FIXME 1.0 not sure this is right, maybe if setuid()
* is going to work then setgroups() should also work.
*/
if (setgroups (0, NULL) < 0)
@@ -494,7 +494,7 @@
* UNIX. If an error occurs, the contents of "filename" are
* undefined. The error is never set if the function succeeds.
*
- * @todo for thread safety, I think we have to use
+ * @todo 1.0 for thread safety, I think we have to use
* readdir_r(). (GLib has the same issue, should file a bug.)
*
* @param iter the iterator
Index: dbus-sysdeps.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-sysdeps.c,v
retrieving revision 1.109
retrieving revision 1.110
diff -u -d -r1.109 -r1.110
--- dbus-sysdeps.c 30 Aug 2006 01:27:44 -0000 1.109
+++ dbus-sysdeps.c 6 Sep 2006 00:14:06 -0000 1.110
@@ -98,7 +98,7 @@
* Wrapper for setenv(). If the value is #NULL, unsets
* the environment variable.
*
- * @todo if someone can verify it's safe, we could avoid the
+ * @todo 1.0 if someone can verify it's safe, we could avoid the
* memleak when doing an unset.
*
* @param varname name of environment variable
More information about the dbus-commit
mailing list