dbus/dbus dbus-connection.c, 1.130, 1.131 dbus-keyring.c, 1.32, 1.33 dbus-pending-call.c, 1.19, 1.20 dbus-server.c, 1.44, 1.45 dbus-sysdeps-unix.c, 1.1, 1.2 dbus-sysdeps-util-unix.c, 1.2, 1.3 dbus-sysdeps.c, 1.112, 1.113

[John Palmieri]

Update of /cvs/dbus/dbus/dbus
In directory kemper:/tmp/cvs-serv13440/dbus

Modified Files:
	dbus-connection.c dbus-keyring.c dbus-pending-call.c 
	dbus-server.c dbus-sysdeps-unix.c dbus-sysdeps-util-unix.c 
	dbus-sysdeps.c 
Log Message:
* remove a bunch of todo items from the 1.0 list


Index: dbus-connection.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-connection.c,v
retrieving revision 1.130
retrieving revision 1.131
diff -u -d -r1.130 -r1.131
--- dbus-connection.c	8 Sep 2006 17:21:37 -0000	1.130
+++ dbus-connection.c	11 Sep 2006 17:41:21 -0000	1.131
@@ -446,8 +446,6 @@
  * @param connection the connection.
  * @param link the list node and message to queue.
  *
- * @todo 1.0? This needs to wake up the mainloop if it is in
- * a poll/select and this is a multithreaded app.
  */
 void
 _dbus_connection_queue_synthesized_message_link (DBusConnection *connection,

Index: dbus-keyring.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-keyring.c,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -d -r1.32 -r1.33
--- dbus-keyring.c	6 Sep 2006 00:14:06 -0000	1.32
+++ dbus-keyring.c	11 Sep 2006 17:41:21 -0000	1.33
@@ -44,7 +44,7 @@
  * by a single server instance for a fixed period of time, then
  * discarded). Also, the keys are not sent over the wire.
  *
- * @todo 1.0? there's a memory leak on some codepath in here, I saw it once
+ * @todo there's a memory leak on some codepath in here, I saw it once
  * when running make check - probably some specific initial cookies
  * present in the cookie file, then depending on what we do with them.
  */

Index: dbus-pending-call.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-pending-call.c,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -d -r1.19 -r1.20
--- dbus-pending-call.c	6 Sep 2006 00:14:06 -0000	1.19
+++ dbus-pending-call.c	11 Sep 2006 17:41:21 -0000	1.20
@@ -624,8 +624,9 @@
  * If the pending call is already completed, this function returns
  * immediately.
  *
- * @todo 1.0? when you start blocking, the timeout is reset, but it should
+ * @todo when you start blocking, the timeout is reset, but it should
  * really only use time remaining since the pending call was created.
+ * This requires storing timestamps instead of intervals in the timeout
  *
  * @param pending the pending call
  */

Index: dbus-server.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-server.c,v
retrieving revision 1.44
retrieving revision 1.45
diff -u -d -r1.44 -r1.45
--- dbus-server.c	6 Sep 2006 00:14:06 -0000	1.44
+++ dbus-server.c	11 Sep 2006 17:41:21 -0000	1.45
@@ -558,13 +558,6 @@
                   goto out;
                 }
               
-              /* FIXME 1.0 - we will unconditionally unlink() the path if
-               * we don't support abstract namespace.  unlink() does
-               * not follow symlinks, but would like independent
-               * confirmation this is safe enough. See also
-               * _dbus_listen_unix_socket() and comments therein.
-               */
-
               /* Always use abstract namespace if possible with tmpdir */
               
               server =

Index: dbus-sysdeps-unix.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-sysdeps-unix.c,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- dbus-sysdeps-unix.c	10 Sep 2006 21:37:10 -0000	1.1
+++ dbus-sysdeps-unix.c	11 Sep 2006 17:41:21 -0000	1.2
@@ -455,7 +455,7 @@
     }
   else
     {
-      /* FIXME discussed security implications of this with Nalin,
+      /* Discussed security implications of this with Nalin,
        * and we couldn't think of where it would kick our ass, but
        * it still seems a bit sucky. It also has non-security suckage;
        * really we'd prefer to exit if the socket is already in use.

Index: dbus-sysdeps-util-unix.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-sysdeps-util-unix.c,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -d -r1.2 -r1.3
--- dbus-sysdeps-util-unix.c	6 Sep 2006 00:14:06 -0000	1.2
+++ dbus-sysdeps-util-unix.c	11 Sep 2006 17:41:21 -0000	1.3
@@ -252,7 +252,8 @@
   /* setgroups() only works if we are a privileged process,
    * so we don't return error on failure; the only possible
    * failure is that we don't have perms to do it.
-   * FIXME 1.0 not sure this is right, maybe if setuid()
+   *
+   * not sure this is right, maybe if setuid()
    * is going to work then setgroups() should also work.
    */
   if (setgroups (0, NULL) < 0)

Index: dbus-sysdeps.c
===================================================================
RCS file: /cvs/dbus/dbus/dbus/dbus-sysdeps.c,v
retrieving revision 1.112
retrieving revision 1.113
diff -u -d -r1.112 -r1.113
--- dbus-sysdeps.c	10 Sep 2006 21:37:10 -0000	1.112
+++ dbus-sysdeps.c	11 Sep 2006 17:41:21 -0000	1.113
@@ -75,8 +75,10 @@
  * Wrapper for setenv(). If the value is #NULL, unsets
  * the environment variable.
  *
- * @todo 1.0 if someone can verify it's safe, we could avoid the
- * memleak when doing an unset.
+ * There is an unfixable memleak in that it is unsafe to
+ * free memory malloced for use with setenv. This is because
+ * we can not rely on internal implementation details of
+ * the underlying libc library.
  *
  * @param varname name of environment variable
  * @param value value of environment variable