Hardcoded FIELD_REPLY_SERIAL in append_{,u}int_field ()

Havoc Pennington hp@redhat.com
Fri, 27 Jun 2003 23:12:35 -0400


On Sat, Jun 28, 2003 at 05:02:57AM +0200, Miloslav Trmac wrote:
> append_{,u}int_field () in dbus/dbus-message.c currently reference
> the header field both by [FIELD_REPLY_SERIAL] and by [field].
> Due to the way they are called, this currently causes no problems.
> Anyway, either the "field" parameter is redundant, or FIELD_REPLY_SERIAL
> should be replaced by field. Attached patch does the latter.

Thanks, this patch looks right. 

(Maybe you should send me a login/passwd if you haven't, if you're
planning to do lots of patches ;-)) 

Havoc