api addition for activation

Havoc Pennington hp@redhat.com
Mon, 12 May 2003 17:53:01 -0400


On Sun, May 11, 2003 at 11:28:15PM -0500, James Willcox wrote:
> Hi,
> 
> Here's a small addition adding dbus_bus_activate_service().  It also
> adds a servicedir tag to session.conf.in.  Ok to commit?
> 
 
+  <servicedir>@prefix@/lib/dbus-1.0/services</servicedir>
+

This should be @libdir@/dbus-1.0 in case someone does --libdir

Well, more specifically you have to do the EXPANDED_LIBDIR thing done 
in a couple other places.

+  dbus_message_append_args (msg, DBUS_TYPE_STRING, service_name,
+      			    DBUS_TYPE_UINT32, 0, 0);

termination should be DBUS_TYPE_INVALID rather than 0 IMHO.
There are probably existing places where this could be fixed.
 
+dbus_bool_t     dbus_bus_activate_service (DBusConnection *connection,
+					   const char     *service_name,
+					   DBusError      *error);

There's a uint32 out param for activate service that should probably
be here.

Havoc