[patch] add some allows to default session.conf.in

Havoc Pennington hp at redhat.com
Sun Aug 8 19:29:20 PDT 2004


On Sun, 2004-08-08 at 13:07, Colin Walters wrote:
> So it seems it's *replies* to the AddMatch method call that are being denied.

If you set "no reply expected" on the AddMatch why are you expecting a
reply? i.e. in what situation did you encounter this bug?

(Do the standard bindings/convenience functions set no reply requested
on AddMatch?)

> So we need to allow non-requested replies too.  The attached patch
> should be better:

Not quite right I think, 
        
        .PP
        A single <deny> rule may specify combinations of attributes such
        as
        send_service and send_interface and send_type. In this case, the
        denial applies only if both attributes match the message being
        denied.
        e.g. <deny send_interface="foo.bar" send_service="foo.blah"/>
        would
        deny messages of the given interface AND to the given service.
        To get an OR effect you specify multiple <deny> rules.
        
So you really want to add an additional <deny>

It seems logical to by default deny replies that the sender didn't ask
for though, don't you think?

Havoc




More information about the dbus mailing list