[PATCH] Trivial segfaults in Python bindings

Seth Nickell seth@gnome.org
Mon, 02 Feb 2004 17:07:57 -0500


Hi Andrew,

Have you tried using the python test-client and test-service code in the
example/ subdir after making these changes? When I apply the patch and
try to run them I get errors.

-Seth

On Sat, 2004-01-31 at 03:29, Andrew Bennetts wrote:
> On Sat, Jan 31, 2004 at 12:09:27AM +1100, Andrew Bennetts wrote:
> > The attached patch fixes these problems on the Message class.  Please apply
> > it.  I'll send patches for the rest when I've finished looking at them.  
> 
> And here it is: fixes for the most obvious segfaults in the other Python
> classes.  This patch against CVS, i.e. it doesn't require my previous patch.
> I can generate it relative to my last patch if necessary.
> 
> Some new segfaults that are fixed by this patch:
> 
>     class Foo:
>         def _get_conn(self):
>             return None
>     print dbus_bindings.bus_get_base_service(Foo())
> 
>     print dbus_bindings.PendingCall(None).block()
> 
> Please apply, or give me feedback. :)
> 
> Thanks!
> 
> -Andrew.
>