[PATCH] Message counter fix

[Christian Hammond]

On Thu, Jul 08, 2004 at 02:55:46PM -0400, Havoc Pennington wrote:
> On Wed, 2003-07-07 at 00:11, Christian Hammond wrote:
> > I noticed that after keeping a couple of D-BUS apps running 24/7 for a
> > few days that D-BUS would report that the service's outgoing message
> > queue was full. After writing a small test app that just sent 5
> > messages and called dbus_connection_get_outgoing_size() before and
> > after each, I realized the counter wasn't being reduced.
> > 
> > The attached one-liner patch fixed the problem for me. Not being an
> > _dbus_message_remove_size_counter() was incrementing by
> > size_counter_delta rather than decrementing by it. I assume the new
> > behavior is correct.
> 
> Thanks, looks like a correct patch. Please commit.
> 
> Havoc

I'd love to, but I don't believe I have commit access :)

(Unless you meant someone else.)

As this is a pretty good-sized problem in some cases, do you think it
would be worthwhile to get this patch in the FC2 rpms for dbus 0.21?

Christian

-- 
Christian Hammond         <>  The Galago Project
chipx86 at gnupdate.org      <>  http://galago.sourceforge.net/
   The surest sign that intelligent life exists elsewhere in the universe is
   that it has never tried to contact us.
      -- Calvin and Hobbes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://freedesktop.org/pipermail/dbus/attachments/20040708/73758f34/attachment.pgp