busy loop ...

Havoc Pennington hp@redhat.com
Sat, 06 Mar 2004 10:16:20 -0500


On Fri, 2004-03-05 at 12:02, Michael Meeks wrote:
> --- dbus/dbus-connection.c    2 Dec 2003 10:44:21 -0000       1.75
> +++ bus/dbus-connection.c    5 Mar 2004 17:05:51 -0000
> @@ -1915,7 +1918,9 @@ _dbus_connection_block_for_reply (DBusCo
>     
>    _dbus_get_current_time (&tv_sec, &tv_usec);
>     
> -  if (tv_sec < start_tv_sec)
> +  if (!dbus_connection_get_is_connected (connection))
> +    return NULL;
> +  else if (tv_sec < start_tv_sec)

If I'm reading the code properly you need to use the _unlocked() flavor
of get_is_connected(), as the connection lock is held here.

Looks good to commit with that change, thanks.

Havoc